Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1761)

Unified Diff: Source/web/PageWidgetDelegate.cpp

Issue 893683003: Implement top controls show/hide functionality for main thread scrolling (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix hiding at the page bottom issue Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/web/TopControls.h » ('j') | Source/web/TopControls.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/PageWidgetDelegate.cpp
diff --git a/Source/web/PageWidgetDelegate.cpp b/Source/web/PageWidgetDelegate.cpp
index 72341ae700d6de189ef837d60138eaab10b6b086..ac7bcdfa5d2607f1eab095ba6ff4104e55187ad5 100644
--- a/Source/web/PageWidgetDelegate.cpp
+++ b/Source/web/PageWidgetDelegate.cpp
@@ -156,6 +156,9 @@ bool PageWidgetDelegate::handleInputEvent(PageWidgetEventHandler& handler, const
case WebInputEvent::GestureScrollUpdate:
case WebInputEvent::GestureFlingStart:
case WebInputEvent::GestureFlingCancel:
+ case WebInputEvent::GesturePinchBegin:
aelias_OOO_until_Jul13 2015/02/13 02:03:17 Touchscreen pinch events can't happen on the main
aelias_OOO_until_Jul13 2015/02/13 02:03:17 Not sure what this has to do with the rest of the
majidvp 2015/02/18 21:03:56 Removed pinch handling logic/tests for not and ret
+ case WebInputEvent::GesturePinchEnd:
+ case WebInputEvent::GesturePinchUpdate:
case WebInputEvent::GestureTap:
case WebInputEvent::GestureTapUnconfirmed:
case WebInputEvent::GestureTapDown:
@@ -175,14 +178,6 @@ bool PageWidgetDelegate::handleInputEvent(PageWidgetEventHandler& handler, const
return false;
return handler.handleTouchEvent(*root, static_cast<const WebTouchEvent&>(event));
- case WebInputEvent::GesturePinchBegin:
- case WebInputEvent::GesturePinchEnd:
- case WebInputEvent::GesturePinchUpdate:
- // FIXME: Once PlatformGestureEvent is updated to support pinch, this
- // should call handleGestureEvent, just like it currently does for
- // gesture scroll.
- return false;
-
default:
return false;
}
« no previous file with comments | « no previous file | Source/web/TopControls.h » ('j') | Source/web/TopControls.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698