Issue 893573003: Do not embed interceptor in handler.

Issue 893573003: Do not embed interceptor in handler. (Closed)

Created:
5 years, 10 months ago by ulan

Modified:
5 years, 10 months ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Do not embed interceptor in handler. BUG=v8:3629 LOG=N Committed: https://crrev.com/5e4951b89990e5198afd59e02fa2abdc91d77873 Cr-Commit-Position: refs/heads/master@{#26363}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -77 lines)			Patch
M	src/ic/arm/handler-compiler-arm.cc	View	1 chunk	+3 lines, -9 lines	0 comments	Download
M	src/ic/arm64/handler-compiler-arm64.cc	View	1 chunk	+5 lines, -11 lines	0 comments	Download
M	src/ic/handler-compiler.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/ic/ia32/handler-compiler-ia32.cc	View	1 chunk	+3 lines, -9 lines	0 comments	Download
M	src/ic/ic.cc	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	src/ic/mips/handler-compiler-mips.cc	View	1 chunk	+4 lines, -10 lines	0 comments	Download
M	src/ic/mips64/handler-compiler-mips64.cc	View	1 chunk	+4 lines, -10 lines	0 comments	Download
M	src/ic/x64/handler-compiler-x64.cc	View	1 chunk	+3 lines, -8 lines	0 comments	Download
M	src/ic/x87/handler-compiler-x87.cc	View	1 chunk	+3 lines, -9 lines	0 comments	Download

Total messages: 7 (2 generated)

ulan

PTAL. Instead embedding the interceptor in handler, we can just fetch it in runtime.

5 years, 10 months ago (2015-01-30 14:44:26 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893573003/1

5 years, 10 months ago (2015-01-30 16:03:27 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-01-30 16:35:05 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5e4951b89990e5198afd59e02fa2abdc91d77873
Cr-Commit-Position: refs/heads/master@{#26363}