Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: src/ic/arm/handler-compiler-arm.cc

Issue 893573003: Do not embed interceptor in handler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ic/arm64/handler-compiler-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex); 206 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex);
207 __ cmp(scratch, ip); 207 __ cmp(scratch, ip);
208 __ b(ne, miss); 208 __ b(ne, miss);
209 } 209 }
210 210
211 211
212 static void PushInterceptorArguments(MacroAssembler* masm, Register receiver, 212 static void PushInterceptorArguments(MacroAssembler* masm, Register receiver,
213 Register holder, Register name, 213 Register holder, Register name,
214 Handle<JSObject> holder_obj) { 214 Handle<JSObject> holder_obj) {
215 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsNameIndex == 0); 215 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsNameIndex == 0);
216 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsInfoIndex == 1); 216 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsThisIndex == 1);
217 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsThisIndex == 2); 217 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsHolderIndex == 2);
218 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsHolderIndex == 3); 218 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsLength == 3);
219 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsLength == 4);
220 __ push(name); 219 __ push(name);
221 Handle<InterceptorInfo> interceptor(holder_obj->GetNamedInterceptor());
222 DCHECK(!masm->isolate()->heap()->InNewSpace(*interceptor));
223 Register scratch = name;
224 __ mov(scratch, Operand(interceptor));
225 __ push(scratch);
226 __ push(receiver); 220 __ push(receiver);
227 __ push(holder); 221 __ push(holder);
228 } 222 }
229 223
230 224
231 static void CompileCallLoadPropertyWithInterceptor( 225 static void CompileCallLoadPropertyWithInterceptor(
232 MacroAssembler* masm, Register receiver, Register holder, Register name, 226 MacroAssembler* masm, Register receiver, Register holder, Register name,
233 Handle<JSObject> holder_obj, IC::UtilityId id) { 227 Handle<JSObject> holder_obj, IC::UtilityId id) {
234 PushInterceptorArguments(masm, receiver, holder, name, holder_obj); 228 PushInterceptorArguments(masm, receiver, holder, name, holder_obj);
235 __ CallExternalReference(ExternalReference(IC_Utility(id), masm->isolate()), 229 __ CallExternalReference(ExternalReference(IC_Utility(id), masm->isolate()),
(...skipping 511 matching lines...) Expand 10 before | Expand all | Expand 10 after
747 // Return the generated code. 741 // Return the generated code.
748 return GetCode(kind(), Code::NORMAL, name); 742 return GetCode(kind(), Code::NORMAL, name);
749 } 743 }
750 744
751 745
752 #undef __ 746 #undef __
753 } 747 }
754 } // namespace v8::internal 748 } // namespace v8::internal
755 749
756 #endif // V8_TARGET_ARCH_ARM 750 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ic/arm64/handler-compiler-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698