Issue 893533004: [Video Player] Remove the default id of the video player

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 893533004: [Video Player] Remove the default id of the video player (Closed)

Created:
5 years, 10 months ago by yoshiki

Modified:
5 years, 10 months ago

Reviewers:

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2272

Target Ref:
refs/pending/branch-heads/2272

Project:
chromium

Visibility:
Public.

[Video Player] Remove the default id of the video player Setting the default id causes the regression crbug.com/450095, so this patch removes it. BUG=450095 TEST=manually tested TBR=yoshiki@chromium.org Review URL: https://codereview.chromium.org/810483005 Cr-Commit-Position: refs/heads/master@{#312182} (cherry picked from commit f97f8f3fb09375cf82874a96e5ce45b8c8838182) Committed: https://chromium.googlesource.com/chromium/src/+/af6f5dada819732d7940c627c73384e57507a18d

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	ui/file_manager/video_player/js/background.js	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)

yoshiki

5 years, 10 months ago (2015-01-30 07:48:21 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
af6f5dada819732d7940c627c73384e57507a18d (presubmit successful).