Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 810483005: [Video Player] Remove the default id of the video player (Closed)

Created:
5 years, 11 months ago by yoshiki
Modified:
5 years, 11 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Video Player] Remove the default id of the video player Setting the default id causes the regression crbug.com/450095, so this patch removes it. BUG=450095 TEST=manually tested Committed: https://crrev.com/f97f8f3fb09375cf82874a96e5ce45b8c8838182 Cr-Commit-Position: refs/heads/master@{#312182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ui/file_manager/video_player/js/background.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
yoshiki
@yawano-san, could you take a look? Thanks.
5 years, 11 months ago (2015-01-20 07:25:53 UTC) #2
yawano
lgtm. Thank you!
5 years, 11 months ago (2015-01-20 08:06:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810483005/1
5 years, 11 months ago (2015-01-20 10:27:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-20 11:13:34 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 11:14:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f97f8f3fb09375cf82874a96e5ce45b8c8838182
Cr-Commit-Position: refs/heads/master@{#312182}

Powered by Google App Engine
This is Rietveld 408576698