Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2490)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/java/res/layout/app_banner_view.xml

Issue 893483002: Make infobars hide on scroll (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Observer removal Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/Tab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/app_banner_view.xml
diff --git a/chrome/android/java/res/layout/app_banner_view.xml b/chrome/android/java/res/layout/app_banner_view.xml
index 3263699ce0ffb4ac10184d9dd3abb732bc554a0e..fd84f7b80bdc653627cbcc84a19427591ab1ae4e 100644
--- a/chrome/android/java/res/layout/app_banner_view.xml
+++ b/chrome/android/java/res/layout/app_banner_view.xml
@@ -12,76 +12,81 @@
android:focusableInTouchMode="true"
android:layout_width="match_parent"
android:layout_height="wrap_content">
- <!-- View showing the icon. -->
- <ImageView
- android:id="@+id/app_icon"
- android:adjustViewBounds="true"
- android:layout_width="wrap_content"
- android:layout_height="@dimen/app_banner_icon_size"
- android:layout_marginEnd="@dimen/app_banner_icon_margin_end" />
-
- <!-- View showing the app's title. -->
- <TextView
- android:id="@+id/app_title"
- android:textAppearance="@style/AppBannerTitle"
- android:includeFontPadding="false"
- android:lines="1"
- android:ellipsize="end"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:layout_marginTop="@dimen/app_banner_title_margin_top"
- android:layout_marginBottom="@dimen/app_banner_title_margin_bottom" />
-
- <!-- Button that triggers installation and opening of the app. -->
- <Button
- android:id="@+id/app_install_button"
- style="@style/AppBannerButton"
- android:textColor="@color/app_banner_install_button_fg"
- android:ellipsize="end"
- android:singleLine="true"
- android:minHeight="@dimen/app_banner_button_height"
- android:paddingStart="@dimen/app_banner_button_padding_sides"
- android:paddingEnd="@dimen/app_banner_button_padding_sides"
- android:paddingTop="@dimen/app_banner_button_padding_above_below"
- android:paddingBottom="@dimen/app_banner_button_padding_above_below"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:layout_marginTop="@dimen/app_banner_button_margin_top" />
-
- <!-- Logo for the store. -->
- <ImageView
- android:id="@+id/store_logo"
- android:src="@drawable/google_play_logo"
- android:adjustViewBounds="true"
- android:layout_width="wrap_content"
- android:layout_height="@dimen/app_banner_logo_height"
- android:layout_marginTop="@dimen/app_banner_logo_margin_top"
- android:layout_marginBottom="@dimen/app_banner_logo_margin_bottom"
- android:layout_marginEnd="@dimen/app_banner_logo_margin_end"/>
-
- <!-- View showing how well the app is rated. -->
- <org.chromium.chrome.browser.banners.RatingView
- android:id="@+id/app_rating"
- android:adjustViewBounds="true"
- android:layout_width="wrap_content"
- android:layout_height="@dimen/app_banner_star_height" />
-
- <!-- Button that closes the banner. -->
- <ImageButton
- android:id="@+id/close_button"
- android:contentDescription="@string/infobar_close"
- android:adjustViewBounds="true"
- android:src="@drawable/infobar_close_button"
- android:background="@drawable/app_banner_button_close"
- android:padding="@dimen/app_banner_close_button_padding"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"/>
-
- <!-- View covering the entire banner. Used to indicate the banner is highlighted. -->
- <View
- android:id="@+id/banner_highlight"
- android:background="@color/app_banner_card_highlight"
- android:visibility="gone"
+ <FrameLayout
+ android:id="@+id/banner_container"
android:layout_width="match_parent"
- android:layout_height="match_parent" />
+ android:layout_height="wrap_content">
+ <!-- View showing the icon. -->
+ <ImageView
+ android:id="@+id/app_icon"
+ android:adjustViewBounds="true"
+ android:layout_width="wrap_content"
+ android:layout_height="@dimen/app_banner_icon_size"
+ android:layout_marginEnd="@dimen/app_banner_icon_margin_end" />
+
+ <!-- View showing the app's title. -->
+ <TextView
+ android:id="@+id/app_title"
+ android:textAppearance="@style/AppBannerTitle"
+ android:includeFontPadding="false"
+ android:lines="1"
+ android:ellipsize="end"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_marginTop="@dimen/app_banner_title_margin_top"
+ android:layout_marginBottom="@dimen/app_banner_title_margin_bottom" />
+
+ <!-- Button that triggers installation and opening of the app. -->
+ <Button
+ android:id="@+id/app_install_button"
+ style="@style/AppBannerButton"
+ android:textColor="@color/app_banner_install_button_fg"
+ android:ellipsize="end"
+ android:singleLine="true"
+ android:minHeight="@dimen/app_banner_button_height"
+ android:paddingStart="@dimen/app_banner_button_padding_sides"
+ android:paddingEnd="@dimen/app_banner_button_padding_sides"
+ android:paddingTop="@dimen/app_banner_button_padding_above_below"
+ android:paddingBottom="@dimen/app_banner_button_padding_above_below"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_marginTop="@dimen/app_banner_button_margin_top" />
+
+ <!-- Logo for the store. -->
+ <ImageView
+ android:id="@+id/store_logo"
+ android:src="@drawable/google_play_logo"
+ android:adjustViewBounds="true"
+ android:layout_width="wrap_content"
+ android:layout_height="@dimen/app_banner_logo_height"
+ android:layout_marginTop="@dimen/app_banner_logo_margin_top"
+ android:layout_marginBottom="@dimen/app_banner_logo_margin_bottom"
+ android:layout_marginEnd="@dimen/app_banner_logo_margin_end"/>
+
+ <!-- View showing how well the app is rated. -->
+ <org.chromium.chrome.browser.banners.RatingView
+ android:id="@+id/app_rating"
+ android:adjustViewBounds="true"
+ android:layout_width="wrap_content"
+ android:layout_height="@dimen/app_banner_star_height" />
+
+ <!-- Button that closes the banner. -->
+ <ImageButton
+ android:id="@+id/close_button"
+ android:contentDescription="@string/infobar_close"
+ android:adjustViewBounds="true"
+ android:src="@drawable/infobar_close_button"
+ android:background="@drawable/app_banner_button_close"
+ android:padding="@dimen/app_banner_close_button_padding"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"/>
+
+ <!-- View covering the entire banner. Used to indicate the banner is highlighted. -->
+ <View
+ android:id="@+id/banner_highlight"
+ android:background="@color/app_banner_card_highlight"
+ android:visibility="gone"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent" />
+ </FrameLayout>
</org.chromium.chrome.browser.banners.AppBannerView>
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/Tab.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698