Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1997)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 893483002: Make infobars hide on scroll (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Observer removal Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
index 5091dccfc0f094072c2e25a5e3868816c8e5ef91..cf42f8912a8f2e9335206f488baff4aa066eaadd 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
@@ -1252,7 +1252,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
updateTitle();
removeSadTabIfPresent();
- mInfoBarContainer.onPageStarted();
if (getContentViewCore() != null) {
getContentViewCore().stopCurrentAccessibilityNotifications();
@@ -1358,10 +1357,11 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
// initialized.
WebContents webContents = mContentViewCore.getWebContents();
mInfoBarContainer = new InfoBarContainer(
- mContext, getId(), mContentViewParent, webContents);
+ mContext, getId(), mContentViewParent, webContents, this);
} else {
mInfoBarContainer.onParentViewChanged(getId(), mContentViewParent);
}
+ mInfoBarContainer.setContentViewCore(mContentViewCore);
if (AppBannerManager.isEnabled() && mAppBannerManager == null) {
mAppBannerManager = new AppBannerManager(this);
@@ -1766,6 +1766,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
if (mInfoBarContainer != null && mInfoBarContainer.getParent() != null) {
mInfoBarContainer.removeFromParentView();
+ mInfoBarContainer.setContentViewCore(null);
}
mContentViewParent = null;
mContentViewCore.destroy();

Powered by Google App Engine
This is Rietveld 408576698