Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7980)

Unified Diff: content/renderer/service_worker/embedded_worker_context_client.h

Issue 893363003: ServiceWorker: Support SWRegistration.unregister() in SWGlobalScope [1/2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update header comment2 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/embedded_worker_context_client.h
diff --git a/content/renderer/service_worker/embedded_worker_context_client.h b/content/renderer/service_worker/embedded_worker_context_client.h
index 9bdbecaecf7721b15e9a99b6fe58ba5bb7cbf52e..8c275b40329ac5c112865dc3e76d1e342e912f85 100644
--- a/content/renderer/service_worker/embedded_worker_context_client.h
+++ b/content/renderer/service_worker/embedded_worker_context_client.h
@@ -25,6 +25,7 @@ class TaskRunner;
namespace blink {
class WebDataSource;
+class WebServiceWorkerProvider;
}
namespace content {
@@ -34,9 +35,9 @@ class ServiceWorkerScriptContext;
class ThreadSafeSender;
// This class provides access to/from an embedded worker's WorkerGlobalScope.
-// All methods other than the constructor (it's created on the main thread)
-// and createServiceWorkerNetworkProvider (also called on the main thread)
-// are called on the worker thread.
+// The ctor, workerContextFailedToStart, createServiceWorkerNetworkProvider and
+// createServiceWorkerProvider are called on the main thread. Others are called
+// on the worker thread.
falken 2015/02/05 12:07:18 Seems better to keep track of by saying "Unless ot
nhiroki 2015/02/06 01:57:31 Done.
//
// TODO(kinuko): Currently EW/SW separation is made a little hazily.
// This should implement WebEmbeddedWorkerContextClient
@@ -105,6 +106,7 @@ class EmbeddedWorkerContextClient
bool accept_connection);
virtual blink::WebServiceWorkerNetworkProvider*
createServiceWorkerNetworkProvider(blink::WebDataSource* data_source);
+ virtual blink::WebServiceWorkerProvider* createServiceWorkerProvider();
virtual void postMessageToClient(
int client_id,
const blink::WebString& message,

Powered by Google App Engine
This is Rietveld 408576698