ServiceWorker: Support SWRegistration.unregister() in SWGlobalScope [1/2]

content/renderer/service_worker/embedded_worker_context_client.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_SERVICE_WORKER_EMBEDDED_WORKER_CONTEXT_CLIENT_H_
 #define CONTENT_RENDERER_SERVICE_WORKER_EMBEDDED_WORKER_CONTEXT_CLIENT_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
 #include "content/common/service_worker/service_worker_types.h"
 #include "ipc/ipc_listener.h"
 #include "third_party/WebKit/public/platform/WebServiceWorkerClientFocusCallback.h"
 #include "third_party/WebKit/public/platform/WebServiceWorkerClientsInfo.h"
 #include "third_party/WebKit/public/platform/WebServiceWorkerEventResult.h"
 #include "third_party/WebKit/public/platform/WebServiceWorkerSkipWaitingCallbacks.h"
 #include "third_party/WebKit/public/platform/WebURL.h"
 #include "third_party/WebKit/public/web/WebServiceWorkerContextClient.h"
 #include "url/gurl.h"
 
 namespace base {
 class MessageLoopProxy;
 class TaskRunner;
 }
 
 namespace blink {
 class WebDataSource;
+class WebServiceWorkerProvider;
 }
 
 namespace content {
 
 class ServiceWorkerProviderContext;
 class ServiceWorkerScriptContext;
 class ThreadSafeSender;
 
 // This class provides access to/from an embedded worker's WorkerGlobalScope.
-// All methods other than the constructor (it's created on the main thread)
-// and createServiceWorkerNetworkProvider (also called on the main thread)
-// are called on the worker thread.
+// The ctor, workerContextFailedToStart, createServiceWorkerNetworkProvider and
+// createServiceWorkerProvider are called on the main thread. Others are called
+// on the worker thread.

[falken, 2015/02/05 12:07:18]

Seems better to keep track of by saying "Unless otherwise noted, all methods are
called on the worker thread". And then note the exceptions above the individual
functions.

[nhiroki, 2015/02/06 01:57:31]

Done.

 //
 // TODO(kinuko): Currently EW/SW separation is made a little hazily.
 // This should implement WebEmbeddedWorkerContextClient
 // or sort of it (which doesn't exist yet) rather than
 // WebServiceWorkerContextClient if we want to separate them more cleanly,
 // or ServiceWorkerScriptContext should be merged into this class
 // if we consider EW == SW script context.
 class EmbeddedWorkerContextClient
     : public blink::WebServiceWorkerContextClient {
  public:
@@ skipping 48 matching lines @@
   virtual void didHandleNotificationClickEvent(
       int request_id,
       blink::WebServiceWorkerEventResult result);
   virtual void didHandlePushEvent(int request_id,
                                   blink::WebServiceWorkerEventResult result);
   virtual void didHandleSyncEvent(int request_id);
   virtual void didHandleCrossOriginConnectEvent(int request_id,
                                                 bool accept_connection);
   virtual blink::WebServiceWorkerNetworkProvider*
       createServiceWorkerNetworkProvider(blink::WebDataSource* data_source);
+  virtual blink::WebServiceWorkerProvider* createServiceWorkerProvider();
   virtual void postMessageToClient(
       int client_id,
       const blink::WebString& message,
       blink::WebMessagePortChannelArray* channels);
   virtual void postMessageToCrossOriginClient(
       const blink::WebCrossOriginServiceWorkerClient& client,
       const blink::WebString& message,
       blink::WebMessagePortChannelArray* channels);
   virtual void focus(int client_id,
                      blink::WebServiceWorkerClientFocusCallback*);
@@ skipping 28 matching lines @@
   scoped_refptr<ServiceWorkerProviderContext> provider_context_;
 
   base::WeakPtrFactory<EmbeddedWorkerContextClient> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(EmbeddedWorkerContextClient);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_SERVICE_WORKER_EMBEDDED_WORKER_CONTEXT_CLIENT_H_