Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 893333004: Update {virtual,override,final} to follow C++11 style. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
Charlie Reis
CC:
aandrey+blink_chromium.org, avayvod+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, feature-media-reviews_chromium.org, jam, jochen+watch_chromium.org, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, paulirish+reviews_chromium.org, pfeldman, piman+watch_chromium.org, posciak+watch_chromium.org, vsevik, wjia+watch_chromium.org, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=creis@chromium.org Committed: https://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc Cr-Commit-Position: refs/heads/master@{#314647}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -202 lines) Patch
M content/app/android/child_process_service.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_surface_texture.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_android.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator.h View 2 chunks +9 lines, -10 lines 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator_unittest.cc View 1 1 chunk +13 lines, -15 lines 0 comments Download
M content/common/gpu/media/android_video_encode_accelerator.h View 1 chunk +14 lines, -15 lines 0 comments Download
M content/common/gpu/stream_texture_android.h View 1 chunk +17 lines, -17 lines 0 comments Download
M content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/android/content_protocol_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/nested_message_pump_android.h View 1 chunk +6 lines, -7 lines 0 comments Download
M content/renderer/android/address_detector.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/renderer/android/email_detector.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/renderer/android/phone_number_detector.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/renderer/android/renderer_date_time_picker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/gpu/stream_texture_host_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/java/gin_java_bridge_dispatcher.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/java/gin_java_bridge_object.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/java/gin_java_bridge_value_converter.h View 2 chunks +11 lines, -11 lines 0 comments Download
M content/renderer/java/gin_java_bridge_value_converter_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/renderer/media/android/media_source_delegate.h View 2 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/media/android/renderer_demuxer_android.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/android/stream_texture_factory_impl.h View 2 chunks +10 lines, -12 lines 0 comments Download
M content/renderer/media/android/stream_texture_factory_impl.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M content/renderer/media/android/stream_texture_factory_synchronous_impl.h View 1 chunk +10 lines, -12 lines 0 comments Download
M content/renderer/media/android/stream_texture_factory_synchronous_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 3 chunks +5 lines, -6 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/app/shell_crash_reporter_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/browser/shell_devtools_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dcheng
5 years, 10 months ago (2015-02-04 00:49:53 UTC) #1
Charlie Reis
LGTM with style nit. https://codereview.chromium.org/893333004/diff/1/content/common/gpu/media/android_video_decode_accelerator_unittest.cc File content/common/gpu/media/android_video_decode_accelerator_unittest.cc (right): https://codereview.chromium.org/893333004/diff/1/content/common/gpu/media/android_video_decode_accelerator_unittest.cc#newcode37 content/common/gpu/media/android_video_decode_accelerator_unittest.cc:37: ~MockVideoDecodeAcceleratorClient() override{}; nit: Space before ...
5 years, 10 months ago (2015-02-04 20:46:43 UTC) #2
dcheng
https://codereview.chromium.org/893333004/diff/1/content/common/gpu/media/android_video_decode_accelerator_unittest.cc File content/common/gpu/media/android_video_decode_accelerator_unittest.cc (right): https://codereview.chromium.org/893333004/diff/1/content/common/gpu/media/android_video_decode_accelerator_unittest.cc#newcode37 content/common/gpu/media/android_video_decode_accelerator_unittest.cc:37: ~MockVideoDecodeAcceleratorClient() override{}; On 2015/02/04 20:46:43, Charlie Reis wrote: > ...
5 years, 10 months ago (2015-02-04 20:47:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893333004/20001
5 years, 10 months ago (2015-02-04 20:57:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 21:49:20 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 21:51:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc
Cr-Commit-Position: refs/heads/master@{#314647}

Powered by Google App Engine
This is Rietveld 408576698