chrome/browser/resources/md_settings/md_settings.html - Issue 893323002: Add a basic stub Polymer settings page at chrome://md-settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_settings/md_settings.html

Issue 893323002: Add a basic stub Polymer settings page at chrome://md-settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify everything (respond to comments) Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc » ('j') | chrome/browser/ui/webui/md_settings_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_settings/md_settings.html

diff --git a/chrome/browser/resources/md_settings/md_settings.html b/chrome/browser/resources/md_settings/md_settings.html

new file mode 100644

index 0000000000000000000000000000000000000000..2b548473ee6bb32a7af31c3c6432c901d5cd31d6

--- /dev/null

+++ b/chrome/browser/resources/md_settings/md_settings.html

@@ -0,0 +1,18 @@

+<!doctype html>

+<html i18n-values="dir:textdirection;lang:language">

+<head>

+ <meta charset="utf-8">

+ <title>Settings</title>

James Hawkins 2015/02/04 22:46:10 nit: Remove blank line.

Oren Blasberg 2015/02/04 23:09:54 Done.

+ <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css">

James Hawkins 2015/02/04 22:46:10 We're almost certainly not going to use this versi

Oren Blasberg 2015/02/04 23:09:54 Done.

+ <link rel="import" href="chrome://resources/polymer/paper-button/paper-button.html">

James Hawkins 2015/02/04 22:46:10 nit: 80 cols.

Oren Blasberg 2015/02/04 23:09:54 Done.

+</head>

+<body>

+ <header>

+ <h1>Settings</h1>

+ </header>

+ <div class="main">

+ <paper-button id="manage-button" raised>Manage</paper>

James Hawkins 2015/02/04 22:46:10 Did we decide somewhere to not handle i18n for str

stevenjb 2015/02/04 23:00:04 We did. Or at least, I suggested that perhaps we s

+ </div>

+</body>

+</html>