chrome/browser/resources/md_settings/md_settings.html - Issue 893323002: Add a basic stub Polymer settings page at chrome://md-settings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_settings/md_settings.html

Issue 893323002: Add a basic stub Polymer settings page at chrome://md-settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify everything (respond to comments) Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html i18n-values="dir:textdirection;lang:language">

	3 <head>

	4 <meta charset="utf-8">

	5 <title>Settings</title>

	6
	James Hawkins 2015/02/04 22:46:10 nit: Remove blank line. nit: Remove blank line. Oren Blasberg 2015/02/04 23:09:54 Done. Show quoted text On 2015/02/04 22:46:10, James Hawkins wrote: > nit: Remove blank line. Done.
	7 <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css">
	James Hawkins 2015/02/04 22:46:10 We're almost certainly not going to use this versi We're almost certainly not going to use this version of chrome_shared.css (because we'll need to rewrite for MD), so let's not include that here. Oren Blasberg 2015/02/04 23:09:54 Done. Show quoted text On 2015/02/04 22:46:10, James Hawkins wrote: > We're almost certainly not going to use this version of chrome_shared.css > (because we'll need to rewrite for MD), so let's not include that here. Done.
	8 <link rel="import" href="chrome://resources/polymer/paper-button/paper-button. html">
	James Hawkins 2015/02/04 22:46:10 nit: 80 cols. nit: 80 cols. Oren Blasberg 2015/02/04 23:09:54 Done. Show quoted text On 2015/02/04 22:46:10, James Hawkins wrote: > nit: 80 cols. Done.
	9 </head>

	10 <body>

	11 <header>

	12 <h1>Settings</h1>

	13 </header>

	14 <div class="main">

	15 <paper-button id="manage-button" raised>Manage</paper>
	James Hawkins 2015/02/04 22:46:10 Did we decide somewhere to not handle i18n for str Did we decide somewhere to not handle i18n for strings yet? stevenjb 2015/02/04 23:00:04 We did. Or at least, I suggested that perhaps we s Show quoted text On 2015/02/04 22:46:10, James Hawkins wrote: > Did we decide somewhere to not handle i18n for strings yet? We did. Or at least, I suggested that perhaps we should not handle it the old way and Michael agreed. We think we can (and should) get something better working quickly. (Otherwise we have to continue modifying .grd files for every string which is kind of a pita).
	16 </div>

	17 </body>

	18 </html>

OLD	NEW