Chromium Code Reviews Chromium Code Reviews
Issue 893323002:
Add a basic stub Polymer settings page at chrome://md-settings. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/browser/resources/md_settings/md_settings.html |
| diff --git a/chrome/browser/resources/md_settings/md_settings.html b/chrome/browser/resources/md_settings/md_settings.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..abae720235a99d19c8988dae7518080e189ac3a8 |
| --- /dev/null |
| +++ b/chrome/browser/resources/md_settings/md_settings.html |
| @@ -0,0 +1,34 @@ |
| +<!doctype html> |
| +<html i18n-values="dir:textdirection;lang:language"> |
| +<head> |
| + <meta charset="utf-8"> |
| + <title i18n-content="settings_title"></title> |
|
michaelpg
2015/02/04 02:35:29
settingsTitle: useCamelCase (what we use for JS va
Oren Blasberg
2015/02/04 18:31:50
Done.
|
| + |
| + <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css"> |
| + <link rel="import" href="chrome://resources/polymer/paper-button/paper-button.html"> |
| + |
| + <script src="chrome://resources/js/action_link.js"></script> |
| + <script src="chrome://resources/js/cr.js"></script> |
| + <script src="chrome://resources/js/cr/ui.js"></script> |
| + <script src="chrome://resources/js/cr/ui/command.js"></script> |
| + <script src="chrome://resources/js/load_time_data.js"></script> |
| + <script src="chrome://resources/js/util.js"></script> |
| + <script src="strings.js"></script> |
|
stevenjb
2015/02/04 02:19:15
I think we should consider starting with as blank
Jeremy Klein
2015/02/04 02:24:26
+1 to clearing this out for now. Are any of the ab
Oren Blasberg
2015/02/04 18:31:50
Done.
|
| + |
| + <style type="text/css"> |
| + #manage-button { |
| + background: #4182fa; |
| + color: white; |
| + } |
| + </style> |
|
stevenjb
2015/02/04 02:19:15
Iirc, we decided to separate .css from .html?
Oren Blasberg
2015/02/04 18:31:50
Done.
|
| +</head> |
| +<body> |
| + <header> |
| + <h1 i18n-content="settings_title"></h1> |
| + </header> |
| + <div class="main"> |
| + <paper-button id="manage-button" raised>Manage</paper> |
| + </div> |
| + <script src="chrome://resources/js/i18n_template2.js"></script> |
|
stevenjb
2015/02/04 02:19:15
Do we want to start out with the existing chrome i
Jeremy Klein
2015/02/04 02:24:26
I thought we were planning on using the chrome i18
michaelpg
2015/02/04 02:35:29
I'd say skip it. We'll probably use chrome.i18n fo
Oren Blasberg
2015/02/04 18:31:50
Done.
|
| +</body> |
| +</html> |
