chrome/browser/resources/md_settings/md_settings.html - Issue 893323002: Add a basic stub Polymer settings page at chrome://md-settings.

Side by Side Diff: chrome/browser/resources/md_settings/md_settings.html

Issue 893323002: Add a basic stub Polymer settings page at chrome://md-settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Setting the upstream. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc » ('j') | chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html i18n-values="dir:textdirection;lang:language">

	3 <head>

	4 <meta charset="utf-8">

	5 <title i18n-content="settings_title"></title>
	michaelpg 2015/02/04 02:35:29 settingsTitle: useCamelCase (what we use for JS va settingsTitle: useCamelCase (what we use for JS variables) Oren Blasberg 2015/02/04 18:31:50 Done. Show quoted text On 2015/02/04 02:35:29, michaelpg wrote: > settingsTitle: useCamelCase (what we use for JS variables) Done.
	6

	7 <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css">

	8 <link rel="import" href="chrome://resources/polymer/paper-button/paper-button. html">

	9

	10 <script src="chrome://resources/js/action_link.js"></script>

	11 <script src="chrome://resources/js/cr.js"></script>

	12 <script src="chrome://resources/js/cr/ui.js"></script>

	13 <script src="chrome://resources/js/cr/ui/command.js"></script>

	14 <script src="chrome://resources/js/load_time_data.js"></script>

	15 <script src="chrome://resources/js/util.js"></script>

	16 <script src="strings.js"></script>
	stevenjb 2015/02/04 02:19:15 I think we should consider starting with as blank I think we should consider starting with as blank a slate as possible initially, i.e. just chrome_shared.css. Thoughts on that? Jeremy Klein 2015/02/04 02:24:26 +1 to clearing this out for now. Are any of the ab Show quoted text On 2015/02/04 02:19:15, stevenjb wrote: > I think we should consider starting with as blank a slate as possible initially, > i.e. just chrome_shared.css. Thoughts on that? +1 to clearing this out for now. Are any of the above js files still required? Oren Blasberg 2015/02/04 18:31:50 Done. Show quoted text On 2015/02/04 02:24:26, Jeremy Klein wrote: > On 2015/02/04 02:19:15, stevenjb wrote: > > I think we should consider starting with as blank a slate as possible > initially, > > i.e. just chrome_shared.css. Thoughts on that? > > +1 to clearing this out for now. Are any of the above js files still required? Done.
	17

	18 <style type="text/css">

	19 #manage-button {

	20 background: #4182fa;

	21 color: white;

	22 }

	23 </style>
	stevenjb 2015/02/04 02:19:15 Iirc, we decided to separate .css from .html? Iirc, we decided to separate .css from .html? Oren Blasberg 2015/02/04 18:31:50 Done. Show quoted text On 2015/02/04 02:19:15, stevenjb wrote: > Iirc, we decided to separate .css from .html? Done.
	24 </head>

	25 <body>

	26 <header>

	27 <h1 i18n-content="settings_title"></h1>

	28 </header>

	29 <div class="main">

	30 <paper-button id="manage-button" raised>Manage</paper>

	31 </div>

	32 <script src="chrome://resources/js/i18n_template2.js"></script>
	stevenjb 2015/02/04 02:19:15 Do we want to start out with the existing chrome i Do we want to start out with the existing chrome i18n, or skip that and plan to do something better "very soon"? Jeremy Klein 2015/02/04 02:24:26 I thought we were planning on using the chrome i18 Show quoted text On 2015/02/04 02:19:15, stevenjb wrote: > Do we want to start out with the existing chrome i18n, or skip that and plan to > do something better "very soon"? I thought we were planning on using the chrome i18n solution still. Was there a different option available? michaelpg 2015/02/04 02:35:29 I'd say skip it. We'll probably use chrome.i18n fo Show quoted text On 2015/02/04 02:19:15, stevenjb wrote: > Do we want to start out with the existing chrome i18n, or skip that and plan to > do something better "very soon"? I'd say skip it. We'll probably use chrome.i18n for the app. Oren Blasberg 2015/02/04 18:31:50 Done. Show quoted text On 2015/02/04 02:35:29, michaelpg wrote: > On 2015/02/04 02:19:15, stevenjb wrote: > > Do we want to start out with the existing chrome i18n, or skip that and plan > to > > do something better "very soon"? > > I'd say skip it. We'll probably use chrome.i18n for the app. Done.
	33 </body>

	34 </html>

OLD	NEW