Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: test/cctest/test-heap.cc

Issue 893073006: Add map-based read barrier to WeakCell Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/ic/ia32/ic-compiler-ia32.cc ('K') | « src/type-feedback-vector.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-heap.cc
diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc
index ed80bd69811482c87c59e14565e59f273344b6c8..df9a5bb93f8ee0edb56b692f92962bf46d74a28c 100644
--- a/test/cctest/test-heap.cc
+++ b/test/cctest/test-heap.cc
@@ -4710,17 +4710,17 @@ TEST(WeakCell) {
HandleScope inner_scope(isolate);
weak_cell2 = inner_scope.CloseAndEscape(factory->NewWeakCell(survivor));
}
- CHECK(weak_cell1->value()->IsFixedArray());
- CHECK_EQ(*survivor, weak_cell2->value());
+ CHECK(weak_cell1->ValueNoReadBarrier()->IsFixedArray());
+ CHECK_EQ(*survivor, weak_cell2->ValueNoReadBarrier());
heap->CollectGarbage(NEW_SPACE);
- CHECK(weak_cell1->value()->IsFixedArray());
- CHECK_EQ(*survivor, weak_cell2->value());
+ CHECK(weak_cell1->ValueNoReadBarrier()->IsFixedArray());
+ CHECK_EQ(*survivor, weak_cell2->ValueNoReadBarrier());
heap->CollectGarbage(NEW_SPACE);
- CHECK(weak_cell1->value()->IsFixedArray());
- CHECK_EQ(*survivor, weak_cell2->value());
+ CHECK(weak_cell1->ValueNoReadBarrier()->IsFixedArray());
+ CHECK_EQ(*survivor, weak_cell2->ValueNoReadBarrier());
heap->CollectAllAvailableGarbage();
CHECK(weak_cell1->cleared());
- CHECK_EQ(*survivor, weak_cell2->value());
+ CHECK_EQ(*survivor, weak_cell2->ValueNoReadBarrier());
}
@@ -4740,16 +4740,16 @@ TEST(WeakCellsWithIncrementalMarking) {
Handle<HeapObject> value =
i == 0 ? survivor : factory->NewFixedArray(1, NOT_TENURED);
Handle<WeakCell> weak_cell = factory->NewWeakCell(value);
- CHECK(weak_cell->value()->IsFixedArray());
+ CHECK(weak_cell->ValueNoReadBarrier()->IsFixedArray());
IncrementalMarking* marking = heap->incremental_marking();
if (marking->IsStopped()) marking->Start();
marking->Step(128, IncrementalMarking::NO_GC_VIA_STACK_GUARD);
heap->CollectGarbage(NEW_SPACE);
- CHECK(weak_cell->value()->IsFixedArray());
+ CHECK(weak_cell->ValueNoReadBarrier()->IsFixedArray());
weak_cells[i] = inner_scope.CloseAndEscape(weak_cell);
}
heap->CollectAllGarbage(Heap::kNoGCFlags);
- CHECK_EQ(*survivor, weak_cells[0]->value());
+ CHECK_EQ(*survivor, weak_cells[0]->ValueNoReadBarrier());
for (int i = 1; i < N; i++) {
CHECK(weak_cells[i]->cleared());
}
« src/ic/ia32/ic-compiler-ia32.cc ('K') | « src/type-feedback-vector.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698