Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: src/type-feedback-vector.cc

Issue 893073006: Add map-based read barrier to WeakCell Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/type-feedback-vector.cc
diff --git a/src/type-feedback-vector.cc b/src/type-feedback-vector.cc
index 2316f2979951fa285e85eb5d50c72323fafc4856..7cf4ca66b6f1560510e6e96fdd26fa53889e9e50 100644
--- a/src/type-feedback-vector.cc
+++ b/src/type-feedback-vector.cc
@@ -405,7 +405,7 @@ int FeedbackNexus::ExtractMaps(int start_index, MapHandleList* maps) const {
for (int i = start_index; i < array->length(); i += 2) {
WeakCell* cell = WeakCell::cast(array->get(i));
if (!cell->cleared()) {
- Map* map = Map::cast(cell->value());
+ Map* map = Map::cast(cell->value(isolate->heap()));
maps->Add(handle(map, isolate));
found++;
}
@@ -425,7 +425,10 @@ MaybeHandle<Code> FeedbackNexus::FindHandlerForMap(int start_index,
for (int i = start_index; i < array->length(); i += 2) {
WeakCell* cell = WeakCell::cast(array->get(i));
if (!cell->cleared()) {
- Map* array_map = Map::cast(cell->value());
+ // Don't need a read barrier because we immediately
+ // discard the value unless we already had it from
+ // somewhere else.
+ Map* array_map = Map::cast(cell->ValueNoReadBarrier());
if (array_map == *map) {
Code* code = Code::cast(array->get(i + 1));
DCHECK(code->kind() == Code::HANDLER);

Powered by Google App Engine
This is Rietveld 408576698