Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: chrome/browser/ui/omnibox/omnibox_edit_model.cc

Issue 89273002: Eliminate the OmniboxEditModel::GetViewText() method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nuke GetViewText instead. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_edit_model.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/omnibox/omnibox_edit_model.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.cc b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
index eed29522d7370a3d6ecf10fdc4a369b2a70c4c87..550e7180bba2942606f485fbc48027b7709a1243 100644
--- a/chrome/browser/ui/omnibox/omnibox_edit_model.cc
+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
@@ -763,7 +763,7 @@ void OmniboxEditModel::OpenMatch(AutocompleteMatch match,
}
// Get the current text before we call RevertAll() which will clear it.
- string16 current_text = GetViewText();
+ string16 current_text = view_->GetText();
if (disposition != NEW_BACKGROUND_TAB) {
base::AutoReset<bool> tmp(&in_revert_, true);
@@ -1212,10 +1212,6 @@ void OmniboxEditModel::OnCurrentMatchChanged() {
OnPopupDataChanged(inline_autocompletion, NULL, keyword, is_keyword_hint);
}
-string16 OmniboxEditModel::GetViewText() const {
- return view_->GetText();
-}
-
InstantController* OmniboxEditModel::GetInstantController() const {
return controller_->GetInstant();
}
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_edit_model.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698