chrome/browser/ui/omnibox/omnibox_edit_model.h - Issue 89273002: Eliminate the OmniboxEditModel::GetViewText() method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_edit_model.h

Issue 89273002: Eliminate the OmniboxEditModel::GetViewText() method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nuke GetViewText instead. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/omnibox/omnibox_edit_model.h

diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.h b/chrome/browser/ui/omnibox/omnibox_edit_model.h

index 054fd9fda9371ae22fe08db6a9aa8feac8e02c67..2ed122ce22ae604d83871199e32c066b9331739c 100644

--- a/chrome/browser/ui/omnibox/omnibox_edit_model.h

+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.h

@@ -319,9 +319,6 @@ class OmniboxEditModel {

// Called when the current match has changed in the OmniboxController.

void OnCurrentMatchChanged();

- // Access the current view text.

- string16 GetViewText() const;

// TODO(beaudoin): We need this to allow OmniboxController access the

// InstantController via OmniboxEditController, because the only valid pointer

// to InstantController is kept in Browser. We should try to get rid of this,

« no previous file with comments | « no previous file | chrome/browser/ui/omnibox/omnibox_edit_model.cc » ('j') | no next file with comments »