Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 89273002: Eliminate the OmniboxEditModel::GetViewText() method. (Closed)

Created:
7 years ago by Justin Donnelly
Modified:
7 years ago
CC:
chromium-reviews, Greg Billock
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Eliminate the OmniboxEditModel::GetViewText() method. The method is only used one place, which is a somewhat unnecessary call in the same class. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238563

Patch Set 1 #

Patch Set 2 : Nuke GetViewText instead. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/browser/ui/omnibox/omnibox_edit_model.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 1 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Justin Donnelly
Hi Peter - the goal in this change is consistency. I have no opinion about ...
7 years ago (2013-12-02 21:23:56 UTC) #1
Peter Kasting
Since GetViewText() is only used internally and only used once, let's just nuke it and ...
7 years ago (2013-12-02 21:41:48 UTC) #2
Justin Donnelly
On 2013/12/02 21:41:48, Peter Kasting wrote: > Since GetViewText() is only used internally and only ...
7 years ago (2013-12-03 01:52:13 UTC) #3
Peter Kasting
LGTM
7 years ago (2013-12-03 01:54:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdonnelly@chromium.org/89273002/20001
7 years ago (2013-12-03 17:44:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdonnelly@chromium.org/89273002/20001
7 years ago (2013-12-03 19:13:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdonnelly@chromium.org/89273002/20001
7 years ago (2013-12-03 23:41:49 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-04 04:24:05 UTC) #8
Message was sent while issue was closed.
Change committed as 238563

Powered by Google App Engine
This is Rietveld 408576698