Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 892703002: use conics for arcTo (Closed)

Created:
5 years, 10 months ago by reed1
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

use conics for arcTo guarded by SK_SUPPORT_LEGACY_ARCTO_QUADS BUG=skia: Committed: https://skia.googlesource.com/skia/+/d5d27d9b146731b871b1bcc6d6de36fba2d5ea44

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix unittests #

Patch Set 4 : fix the legacy code-path for chrome #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -24 lines) Patch
M src/core/SkGeometry.h View 1 3 chunks +13 lines, -1 line 0 comments Download
M src/core/SkGeometry.cpp View 1 2 1 chunk +86 lines, -0 lines 0 comments Download
M src/core/SkPath.cpp View 1 2 3 4 chunks +50 lines, -21 lines 0 comments Download
M tests/PathTest.cpp View 1 2 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892703002/20001
5 years, 10 months ago (2015-02-09 19:05:47 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-09 19:05:49 UTC) #3
reed1
needs this to land first in chrome https://codereview.chromium.org/905423002/
5 years, 10 months ago (2015-02-09 19:07:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/1974)
5 years, 10 months ago (2015-02-09 19:09:28 UTC) #7
caryclark
lgtm
5 years, 10 months ago (2015-02-09 19:23:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892703002/60001
5 years, 10 months ago (2015-02-09 21:49:19 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 21:54:46 UTC) #12
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/d5d27d9b146731b871b1bcc6d6de36fba2d5ea44

Powered by Google App Engine
This is Rietveld 408576698