Do not announce robot account token before account ID is available

Do not announce robot account token before account ID is available

When announcing the availability of the robot account token to its
observers, DeviceOAuth2TokenService needs to know both the token and
the robot account ID. During enrollment, the token becomes available
before the account ID. Thus, DeviceOAuth2TokenService needs to wait
for the account ID to be available before announcing the token.

BUG=453828
TEST=New unit test

Committed: https://crrev.com/c9e620e90057f214879658eca758493e1ea3cbdb
Cr-Commit-Position: refs/heads/master@{#314312}

[bartfab (slow), 2015-01-30 17:34:39]

bartfab@chromium.org changed reviewers:
+ xiyuan@chromium.org

[bartfab (slow), 2015-01-30 17:34:40]

Hi Xiyuan,

Could you take a look?

There are two more direct owners, but Mattias is on vacation and Yuri no longer
works on Chrome, so I have to default to chrome/browser/chromeos owners.

[xiyuan, 2015-01-30 18:37:03]

https://codereview.chromium.org/892633003/diff/1/chrome/browser/chromeos/sett...
File chrome/browser/chromeos/settings/device_oauth2_token_service.cc (right):

https://codereview.chromium.org/892633003/diff/1/chrome/browser/chromeos/sett...
chrome/browser/chromeos/settings/device_oauth2_token_service.cc:94: //
available.
Should we call OnServiceAccountIdentityChanged here as well just in case the
code is changed in the future and we get the account ID before the token?

[bartfab (slow), 2015-02-02 21:01:07]

https://codereview.chromium.org/892633003/diff/1/chrome/browser/chromeos/sett...
File chrome/browser/chromeos/settings/device_oauth2_token_service.cc (right):

https://codereview.chromium.org/892633003/diff/1/chrome/browser/chromeos/sett...
chrome/browser/chromeos/settings/device_oauth2_token_service.cc:94: //
available.
On 2015/01/30 18:37:03, xiyuan wrote:
> Should we call OnServiceAccountIdentityChanged here as well just in case the
> code is changed in the future and we get the account ID before the token?

Done.

[xiyuan, 2015-02-02 21:07:34]

lgtm

[bartfab (slow), 2015-02-03 09:03:54]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2015-02-03 09:04:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892633003/20001

[commit-bot: I haz the power, 2015-02-03 09:55:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-03 09:55:56]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bartfab (slow), 2015-02-03 10:40:37]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2015-02-03 10:40:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892633003/40001

[commit-bot: I haz the power, 2015-02-03 11:17:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-03 11:18:37]

Patchset 3 (id:??) landed as
https://crrev.com/c9e620e90057f214879658eca758493e1ea3cbdb
Cr-Commit-Position: refs/heads/master@{#314312}