chrome/browser/chromeos/settings/device_oauth2_token_service_factory.h - Issue 892633003: Do not announce robot account token before account ID is available

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/settings/device_oauth2_token_service_factory.h

Issue 892633003: Do not announce robot account token before account ID is available (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unbroke unit tests. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/settings/device_oauth2_token_service.cc ('k') | chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/settings/device_oauth2_token_service_factory.h

diff --git a/chrome/browser/chromeos/settings/device_oauth2_token_service_factory.h b/chrome/browser/chromeos/settings/device_oauth2_token_service_factory.h

index 8b20c88c804966c820e46c6fed7fc3118754e820..ccb370bb42730cedf64164046a4194a3fc739ec5 100644

--- a/chrome/browser/chromeos/settings/device_oauth2_token_service_factory.h

+++ b/chrome/browser/chromeos/settings/device_oauth2_token_service_factory.h

@@ -26,13 +26,13 @@ class DeviceOAuth2TokenServiceFactory {

// Called by ChromeBrowserMainPartsChromeOS in order to bootstrap the

// DeviceOAuth2TokenService instance after the required global data is

- // available (local state and request context getter).

+ // available (local state, request context getter and CrosSettings).

static void Initialize();

// Called by ChromeBrowserMainPartsChromeOS in order to shutdown the

// DeviceOAuth2TokenService instance and cancel all in-flight requests before

- // the required global data is destroyed (local state and request context

- // getter).

+ // the required global data is destroyed (local state, request context getter

+ // and CrosSettings).

static void Shutdown();

private: