Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 892513003: [turbofan] Initial support for Switch. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Initial support for Switch. Adds Switch and Case operators to TurboFan and handles them appropriately in instruction selection and code generation. BUG=v8:3872 LOG=n Committed: https://crrev.com/feb2890711e8072a9550abb89621929816fc9699 Cr-Commit-Position: refs/heads/master@{#26515}

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Updates #

Patch Set 4 : REBASE #

Patch Set 5 : More fixes. #

Patch Set 6 : Fix Wuschelstudio build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+512 lines, -45 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 2 3 4 3 chunks +22 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 2 3 4 3 chunks +25 lines, -0 lines 0 comments Download
M src/compiler/code-generator.h View 1 2 3 4 3 chunks +14 lines, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 1 2 3 4 5 chunks +35 lines, -1 line 0 comments Download
M src/compiler/code-generator-impl.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/common-operator.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/common-operator.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 3 4 3 chunks +22 lines, -0 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 3 4 5 7 chunks +38 lines, -2 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/operator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/operator.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 2 3 4 5 1 chunk +14 lines, -0 lines 0 comments Download
M src/compiler/schedule.h View 3 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/schedule.cc View 3 chunks +32 lines, -1 line 0 comments Download
M src/compiler/scheduler.cc View 1 2 3 4 5 8 chunks +86 lines, -37 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 3 4 5 3 chunks +23 lines, -0 lines 0 comments Download
M src/disassembler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 2 chunks +36 lines, -0 lines 0 comments Download
M test/unittests/compiler/scheduler-unittest.cc View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-09 08:38:49 UTC) #2
dcarney
lgtm more tests would be nice, but i assume you'll add them later since switches ...
5 years, 10 months ago (2015-02-09 08:53:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892513003/100001
5 years, 10 months ago (2015-02-09 08:54:28 UTC) #5
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 10 months ago (2015-02-09 08:56:06 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 08:56:21 UTC) #7
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/feb2890711e8072a9550abb89621929816fc9699
Cr-Commit-Position: refs/heads/master@{#26515}

Powered by Google App Engine
This is Rietveld 408576698