Chromium Code Reviews| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 46f71a99d38dc07a9c9f82eee752085e781747b7..c9cfbe991f707e8eb8c3300f3e850ad223b399da 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -23260,6 +23260,13 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="PasswordManager.NumEmptyUsernames"> |
|
Ilya Sherman
2015/01/29 20:31:09
nit: Suggested name: "PasswordManager.EmptyUsernam
vasilii
2015/01/30 12:35:41
Done.
|
| + <owner>vasilii@chromium.org</owner> |
| + <summary> |
| + Number of password forms with empty username in the Password Store. |
|
vabr (Chromium)
2015/01/29 15:40:23
Could you please insert a <!--comment--> with a TO
Ilya Sherman
2015/01/29 20:31:09
Please document when this metric is recorded -- at
vasilii
2015/01/30 12:35:41
I didn't find similar comments in the xml. I don't
vasilii
2015/01/30 12:35:41
Done.
|
| + </summary> |
| +</histogram> |
| + |
| <histogram name="PasswordManager.NumPasswordsDeletedByBulkDelete"> |
| <owner>dubroy@chromium.org</owner> |
| <owner>vabr@chromium.org</owner> |
| @@ -23296,6 +23303,13 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="PasswordManager.OfferSaveEmptyUsername"> |
|
Ilya Sherman
2015/01/29 20:31:09
Suggested name: "PasswordManager.EmptyUsernames.Of
Ilya Sherman
2015/01/29 20:31:09
Please associate an enum that's specifically relev
vasilii
2015/01/30 12:35:41
Done.
vasilii
2015/01/30 12:35:42
Done.
|
| + <owner>vasilii@chromium.org</owner> |
| + <summary> |
| + Indicates if the user is proposed to save an empty username. |
|
Ilya Sherman
2015/01/29 20:31:09
Please document when this metric is recorded. So,
vasilii
2015/01/30 12:35:42
Done.
|
| + </summary> |
| +</histogram> |
| + |
| <histogram name="PasswordManager.OsPasswordStatus" |
| enum="PasswordManagerOsPasswordStatus"> |
| <owner>dubroy@chromium.org</owner> |