Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 892443002: Add UMA histograms for tracking empty usernames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
index 7f44b422f408ba9b5ac4573354f48545f3d53e69..52694ee9f385bf57d84416f1ee60a7d95750d9a5 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
+#include "base/metrics/histogram_macros.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/browsing_data/browsing_data_helper.h"
#include "chrome/browser/password_manager/chrome_password_manager_client.h"
@@ -112,6 +113,8 @@ void ManagePasswordsUIController::OnPasswordSubmitted(
origin_ = PendingPassword().origin;
SetState(password_manager::ui::PENDING_PASSWORD_AND_BUBBLE_STATE);
timer_.reset(new base::ElapsedTimer());
+ UMA_HISTOGRAM_BOOLEAN("PasswordManager.OfferSaveEmptyUsername",
vabr (Chromium) 2015/01/29 15:40:23 You might consider putting this in PasswordManager
vasilii 2015/01/30 12:35:41 Done.
+ PendingPassword().username_value.empty());
UpdateBubbleAndIconVisibility();
}
« no previous file with comments | « no previous file | components/password_manager/core/browser/login_database.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698