Chromium Code Reviews

Unified Diff: src/code-factory.cc

Issue 892383003: emit premonomorphic ics for loads/stores in optimized code (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: wire up stores Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « src/code-factory.h ('k') | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-factory.cc
diff --git a/src/code-factory.cc b/src/code-factory.cc
index c64f006c27c5e769f7e35dc161b9b6f2ec82c27d..08bde1d526932c3c15710bf4d1ad3ab997f7bd33 100644
--- a/src/code-factory.cc
+++ b/src/code-factory.cc
@@ -21,13 +21,14 @@ Callable CodeFactory::LoadIC(Isolate* isolate, ContextualMode mode) {
// static
Callable CodeFactory::LoadICInOptimizedCode(Isolate* isolate,
- ContextualMode mode) {
+ ContextualMode mode,
+ bool initialize_megamorphic) {
Toon Verwaest 2015/02/09 12:31:51 What about using an enum (e.g. the state enum) rat
+ auto code = LoadIC::initialize_stub_in_optimized_code(
+ isolate, LoadICState(mode).GetExtraICState(), initialize_megamorphic);
if (FLAG_vector_ics) {
- return Callable(LoadIC::initialize_stub_in_optimized_code(
- isolate, LoadICState(mode).GetExtraICState()),
- VectorLoadICDescriptor(isolate));
+ return Callable(code, VectorLoadICDescriptor(isolate));
}
- return CodeFactory::LoadIC(isolate, mode);
+ return Callable(code, LoadDescriptor(isolate));
}
@@ -67,7 +68,7 @@ Callable CodeFactory::CallICInOptimizedCode(Isolate* isolate, int argc,
// static
Callable CodeFactory::StoreIC(Isolate* isolate, LanguageMode language_mode) {
- return Callable(StoreIC::initialize_stub(isolate, language_mode),
+ return Callable(StoreIC::initialize_stub(isolate, language_mode, false),
StoreDescriptor(isolate));
}
« no previous file with comments | « src/code-factory.h ('k') | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine