src/compiler/js-generic-lowering.cc - Issue 892383003: emit premonomorphic ics for loads/stores in optimized code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-generic-lowering.cc

Issue 892383003: emit premonomorphic ics for loads/stores in optimized code (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: wire up stores Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-generic-lowering.cc

diff --git a/src/compiler/js-generic-lowering.cc b/src/compiler/js-generic-lowering.cc

index d326e806078f83197c5734406a872fa5e360c3d3..06e3edc154cb7ea556995cb1e69553708d5b01bf 100644

--- a/src/compiler/js-generic-lowering.cc

+++ b/src/compiler/js-generic-lowering.cc

@@ -275,7 +275,7 @@ void JSGenericLowering::LowerJSLoadProperty(Node* node) {

void JSGenericLowering::LowerJSLoadNamed(Node* node) {

const LoadNamedParameters& p = LoadNamedParametersOf(node->op());

Callable callable =

- CodeFactory::LoadICInOptimizedCode(isolate(), p.contextual_mode());

+ CodeFactory::LoadICInOptimizedCode(isolate(), p.contextual_mode(), false);

PatchInsertInput(node, 1, jsgraph()->HeapConstant(p.name()));

if (FLAG_vector_ics) {

PatchInsertInput(node, 2, jsgraph()->SmiConstant(p.feedback().index()));