Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 892213003: Fetch global object from jsproxy prototype instead of embedding it in StoreGlobal. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fetch global object from jsproxy prototype instead of embedding it in StoreGlobal. BUG=v8:3629 LOG=N Committed: https://crrev.com/34b72eca3598b327a7e32ab1264081e491c4d6a1 Cr-Commit-Position: refs/heads/master@{#26385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M src/code-stubs.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +14 lines, -5 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
Hi Toon, could you please take a look?
5 years, 10 months ago (2015-02-02 16:40:01 UTC) #2
Toon Verwaest
lgtm
5 years, 10 months ago (2015-02-02 17:28:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892213003/1
5 years, 10 months ago (2015-02-02 17:36:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 17:56:35 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 17:56:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34b72eca3598b327a7e32ab1264081e491c4d6a1
Cr-Commit-Position: refs/heads/master@{#26385}

Powered by Google App Engine
This is Rietveld 408576698