src/ic/ic.cc - Issue 892213003: Fetch global object from jsproxy prototype instead of embedding it in StoreGlobal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 892213003: Fetch global object from jsproxy prototype instead of embedding it in StoreGlobal. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index 17d4ee211e69539d82804171fe94f2f71940c67d..68c11596ebae2509984ceb0a5246cd61b356b02c 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -1747,6 +1747,8 @@ Handle<Code> StoreIC::CompileHandler(LookupIterator* lookup,

if (holder->IsGlobalObject()) {

Handle<PropertyCell> cell = lookup->GetPropertyCell();

Handle<HeapType> union_type = PropertyCell::UpdatedType(cell, value);

+ DCHECK(holder.is_identical_to(receiver) ||

+ receiver->map()->prototype() == *holder);

StoreGlobalStub stub(isolate(), union_type->IsConstant(),

receiver->IsJSGlobalProxy());

Handle<Code> code = stub.GetCodeCopyFromTemplate(

« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | no next file » | no next file with comments »