src/typing.cc - Issue 892113002: Super Constructor Calls need to use a vector slot, not an ic slot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typing.cc

Issue 892113002: Super Constructor Calls need to use a vector slot, not an ic slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: REBASE. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/typing.cc

diff --git a/src/typing.cc b/src/typing.cc

index ec0196e8c0c2fbc129b32b33c830d398c129a227..0a7ba618390a8df4852be5b1f6da35832f6bb740 100644

--- a/src/typing.cc

+++ b/src/typing.cc

@@ -532,8 +532,8 @@ void AstTyper::VisitCall(Call* expr) {

// Collect type feedback.

RECURSE(Visit(expr->expression()));

bool is_uninitialized = true;

- if (expr->IsUsingCallFeedbackSlot(isolate())) {

- FeedbackVectorICSlot slot = expr->CallFeedbackSlot();

+ if (expr->IsUsingCallFeedbackICSlot(isolate())) {

+ FeedbackVectorICSlot slot = expr->CallFeedbackICSlot();

is_uninitialized = oracle()->CallIsUninitialized(slot);

if (!expr->expression()->IsProperty() &&

oracle()->CallIsMonomorphic(slot)) {

« no previous file with comments | « src/type-feedback-vector.h ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »