Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(158)

Issue 8921011: Merge 113852 - Fix failure to disable cloud print connector. (Closed)

Created:
6 years ago by Albert Bodenhamer
Modified:
6 years ago
Reviewers:
Albert Bodenhamer
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 113852 - Fix failure to disable cloud print connector. Fix issue where a crash in the cloud print connector on shutdown will prevent the enable pref change from being persisted. Moves the write of the pref to earlier in the shutdown process so that if a crash occurs the pref will still be recorded. BUG=106919 TEST=Verify 106919 Review URL: http://codereview.chromium.org/8879040 TBR=abodenha@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/service/cloud_print/cloud_print_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
Trybot results:

Messages

Total messages: 2 (0 generated)
Albert Bodenhamer
6 years ago (2011-12-12 18:13:46 UTC) #1
Albert Bodenhamer
6 years ago (2011-12-12 18:15:19 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 0eb02b776