Chromium Code Reviews
Help | Chromium Project | Sign in
(312)

Issue 8921011: Merge 113852 - Fix failure to disable cloud print connector. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by Albert Bodenhamer
Modified:
2 years, 4 months ago
Reviewers:
Albert Bodenhamer
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

Merge 113852 - Fix failure to disable cloud print connector.
Fix issue where a crash in the cloud print connector on shutdown will prevent the enable pref change from being persisted.
Moves the write of the pref to earlier in the shutdown process so that if a crash occurs the pref will still be recorded.

BUG=106919
TEST=Verify 106919


Review URL: http://codereview.chromium.org/8879040

TBR=abodenha@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Lint Patch
M chrome/service/cloud_print/cloud_print_proxy.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Albert Bodenhamer
2 years, 4 months ago #1
Albert Bodenhamer
2 years, 4 months ago #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434