Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 8879040: Fix failure to disable cloud print connector. (Closed)

Created:
9 years ago by Albert Bodenhamer
Modified:
9 years ago
Reviewers:
gene
CC:
chromium-reviews
Visibility:
Public.

Description

Fix failure to disable cloud print connector. Fix issue where a crash in the cloud print connector on shutdown will prevent the enable pref change from being persisted. Moves the write of the pref to earlier in the shutdown process so that if a crash occurs the pref will still be recorded. BUG=106919 TEST=Verify 106919 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/service/cloud_print/cloud_print_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Albert Bodenhamer
9 years ago (2011-12-08 23:57:13 UTC) #1
gene
lgtm
9 years ago (2011-12-08 23:58:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/8879040/1
9 years ago (2011-12-09 00:13:54 UTC) #3
commit-bot: I haz the power
Try job failure for 8879040-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-12-09 01:16:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/8879040/1
9 years ago (2011-12-09 17:16:50 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-09 22:11:03 UTC) #6
Change committed as 113852

Powered by Google App Engine
This is Rietveld 408576698