Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 892083003: Revert Implement <select> Popup Menu using PagePopup (Closed)

Created:
5 years, 10 months ago by vsevik
Modified:
5 years, 10 months ago
Reviewers:
keishi, Nate Chapin
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, blink-reviews-html_chromium.org, zoltan1, blink-reviews-css, sof, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, Dominik Röttsches, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-rendering, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert Implement <select> Popup Menu using PagePopup Reverting: https://codereview.chromium.org/736883002 Reason: breaks layout test: compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Foverflow%2Fupdate-widget-positions-on-nested-frames-and-scrollers.html&testType=layout-tests This patch also reverts the following CLs (oilpan build fix and ex-pectations rebaseline): https://codereview.chromium.org/871373016 https://codereview.chromium.org/889183002 BUG=346582 TBR=keishi@chromium.org,japhet@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1588 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/resources/picker-common.js View 1 chunk +7 lines, -11 lines 0 comments Download
M LayoutTests/fast/forms/select/menulist-popup-open-hide-using-keyboard.html View 4 chunks +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/forms/select/popup-menu-appearance.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/forms/select/popup-menu-appearance-empty.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/forms/select/popup-menu-appearance-empty-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/forms/select/popup-menu-appearance-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/forms/select/popup-menu-appearance-many.html View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/forms/select/popup-menu-appearance-many-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/forms/select/popup-menu-appearance-single-option.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/forms/select/popup-menu-appearance-single-option-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/forms/select/popup-menu-appearance-styled.html View 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/fast/forms/select/popup-menu-appearance-styled-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/forms/select/popup-menu-appearance-transform.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/forms/select/popup-menu-appearance-transform-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/forms/select/popup-menu-ax.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/fast/forms/select/popup-menu-key-operations.html View 1 chunk +0 lines, -131 lines 0 comments Download
D LayoutTests/fast/forms/select/popup-menu-mouse-operations.html View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/fast/forms/select/popup-menu-position.html View 1 chunk +0 lines, -179 lines 0 comments Download
D LayoutTests/platform/android/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/virtual/prefer_compositing_to_lcd_text/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux-x86/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux-x86/virtual/prefer_compositing_to_lcd_text/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/forms/select/popup-menu-appearance-empty-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/forms/select/popup-menu-appearance-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/forms/select/popup-menu-appearance-many-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/forms/select/popup-menu-appearance-single-option-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/forms/select/popup-menu-appearance-styled-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/forms/select/popup-menu-appearance-transform-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/forms/select/popup-menu-appearance-empty-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/forms/select/popup-menu-appearance-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/forms/select/popup-menu-appearance-many-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/forms/select/popup-menu-appearance-single-option-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/forms/select/popup-menu-appearance-styled-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/forms/select/popup-menu-appearance-transform-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-mountainlion/fast/forms/select/popup-menu-appearance-empty-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-mountainlion/fast/forms/select/popup-menu-appearance-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-mountainlion/fast/forms/select/popup-menu-appearance-many-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-mountainlion/fast/forms/select/popup-menu-appearance-single-option-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-mountainlion/fast/forms/select/popup-menu-appearance-styled-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-mountainlion/fast/forms/select/popup-menu-appearance-transform-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/forms/select/popup-menu-appearance-empty-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/forms/select/popup-menu-appearance-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/forms/select/popup-menu-appearance-many-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/forms/select/popup-menu-appearance-single-option-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/forms/select/popup-menu-appearance-styled-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/forms/select/popup-menu-appearance-transform-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/forms/select/popup-menu-appearance-empty-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/forms/select/popup-menu-appearance-empty-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/platform/mac/fast/forms/select/popup-menu-appearance-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/forms/select/popup-menu-appearance-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/platform/mac/fast/forms/select/popup-menu-appearance-many-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/forms/select/popup-menu-appearance-many-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/platform/mac/fast/forms/select/popup-menu-appearance-single-option-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/forms/select/popup-menu-appearance-single-option-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/platform/mac/fast/forms/select/popup-menu-appearance-styled-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/forms/select/popup-menu-appearance-styled-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/platform/mac/fast/forms/select/popup-menu-appearance-transform-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/forms/select/popup-menu-appearance-transform-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/platform/mac/fast/forms/select/popup-menu-ax-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/mac/fast/forms/select/popup-menu-key-operations-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/platform/mac/fast/forms/select/popup-menu-mouse-operations-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/platform/mac/fast/forms/select/popup-menu-position-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/platform/win-xp/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/forms/select/popup-menu-appearance-transform-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/prefer_compositing_to_lcd_text/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/prefer_compositing_to_lcd_text/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers-expected.txt View 1 chunk +0 lines, -143 lines 0 comments Download
M LayoutTests/platform/win/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/forms/select/popup-menu-appearance-empty-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/forms/select/popup-menu-appearance-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/forms/select/popup-menu-appearance-many-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/forms/select/popup-menu-appearance-single-option-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/forms/select/popup-menu-appearance-styled-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/forms/select/popup-menu-appearance-transform-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/forms/select/popup-menu-ax-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/platform/win/fast/forms/select/popup-menu-key-operations-expected.txt View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/platform/win/fast/forms/select/popup-menu-mouse-operations-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/platform/win/fast/forms/select/popup-menu-position-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
M LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers-expected.png View Binary file 0 comments Download
D ManualTests/forms/list-picker.html View 1 chunk +0 lines, -225 lines 0 comments Download
M Source/core/css/CSSFontSelector.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/dom/StyleEngine.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/StyleEngine.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLOptionElement.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/html/HTMLSelectElement.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/html/forms/PopupMenuClient.h View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/page/PagePopup.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/page/PagePopupClient.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderMenuList.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderMenuList.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/web/ColorChooserPopupUIController.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/DateTimeChooserImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ExternalPopupMenuTest.cpp View 3 chunks +0 lines, -9 lines 0 comments Download
D Source/web/PopupMenuImpl.h View 1 chunk +0 lines, -64 lines 0 comments Download
D Source/web/PopupMenuImpl.cpp View 1 chunk +0 lines, -310 lines 0 comments Download
M Source/web/PopupMenuTest.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/web/WebPagePopupImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 3 chunks +0 lines, -19 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
vsevik
5 years, 10 months ago (2015-02-02 10:56:12 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 189329 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698