Source/core/html/forms/PopupMenuClient.h - Issue 892083003: Revert Implement <select> Popup Menu using PagePopup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/PopupMenuClient.h

Issue 892083003: Revert Implement <select> Popup Menu using PagePopup (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/forms/PopupMenuClient.h

diff --git a/Source/core/html/forms/PopupMenuClient.h b/Source/core/html/forms/PopupMenuClient.h

index 00bfbe306e2b90e5f72fb83d6991d94a559ccf5c..2e0d1c33765ee65452883b41a0b82c1055c375ae 100644

--- a/Source/core/html/forms/PopupMenuClient.h

+++ b/Source/core/html/forms/PopupMenuClient.h

@@ -29,9 +29,6 @@

namespace blink {

-class Element;

-class RenderStyle;

class PopupMenuClient {

public:

virtual ~PopupMenuClient() { }

@@ -54,9 +51,6 @@ public:

virtual bool itemIsLabel(unsigned listIndex) const = 0;

virtual bool itemIsSelected(unsigned listIndex) const = 0;

virtual void setTextFromItem(unsigned listIndex) = 0;

- virtual IntRect elementRectRelativeToRootView() const = 0;

- virtual Element& ownerElement() const = 0;

- virtual RenderStyle* renderStyleForItem(Element&) const = 0;

virtual void listBoxSelectItem(int /*listIndex*/, bool /*allowMultiplySelections*/, bool /*shift*/, bool /*fireOnChangeNow*/ = true) { ASSERT_NOT_REACHED(); }

virtual bool multiple() const

« no previous file with comments | « Source/core/html/HTMLSelectElement.h ('k') | Source/core/page/PagePopup.h » ('j') | no next file with comments »