Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 892083002: shell.cc race condition (Closed)

Created:
5 years, 10 months ago by Choongwoo Han
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

shell.cc race condition BUG=v8:3850 LOG=N Committed: https://crrev.com/4bf1f54282da4fd191cc7e25aacc00075857501a Cr-Commit-Position: refs/heads/master@{#26375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M AUTHORS View 2 chunks +2 lines, -1 line 0 comments Download
M samples/shell.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Choongwoo Han
PTAL
5 years, 10 months ago (2015-02-02 06:03:17 UTC) #2
Sven Panne
lgtm
5 years, 10 months ago (2015-02-02 07:37:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892083002/1
5 years, 10 months ago (2015-02-02 07:38:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/288)
5 years, 10 months ago (2015-02-02 07:41:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892083002/1
5 years, 10 months ago (2015-02-02 07:59:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 08:08:23 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 08:08:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bf1f54282da4fd191cc7e25aacc00075857501a
Cr-Commit-Position: refs/heads/master@{#26375}

Powered by Google App Engine
This is Rietveld 408576698