samples/shell.cc - Issue 892083002: shell.cc race condition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/shell.cc

Issue 892083002: shell.cc race condition (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samples/shell.cc

diff --git a/samples/shell.cc b/samples/shell.cc

index 1a08afffdc8ad211ec10adb898ab943427ed1b5b..0ed742d3e368ffbb3d5b60e14020e542ab01fccb 100644

--- a/samples/shell.cc

+++ b/samples/shell.cc

@@ -98,6 +98,7 @@ int main(int argc, char* argv[]) {

result = RunMain(isolate, argc, argv);

if (run_shell) RunShell(context);

}

+ isolate->Dispose();

v8::V8::Dispose();

v8::V8::ShutdownPlatform();

delete platform;

« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »