cc/scheduler/begin_frame_source.h - Issue 891953003: make BeginFrameSourceMixIn's SetNeedsBeginFrame final

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/scheduler/begin_frame_source.h

Issue 891953003: make BeginFrameSourceMixIn's SetNeedsBeginFrame final (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/scheduler/begin_frame_source.h

diff --git a/cc/scheduler/begin_frame_source.h b/cc/scheduler/begin_frame_source.h

index d3dd9de2659f0d8db53c2a42563372a251f5313a..fbf4dbf96948126ef15c1b3d2fa1afe7cd6462b8 100644

--- a/cc/scheduler/begin_frame_source.h

+++ b/cc/scheduler/begin_frame_source.h

@@ -138,7 +138,7 @@ class CC_EXPORT BeginFrameSourceMixIn : public BeginFrameSource {

// BeginFrameSource

bool NeedsBeginFrames() const override;

- void SetNeedsBeginFrames(bool needs_begin_frames) override;

+ void SetNeedsBeginFrames(bool needs_begin_frames) final;

void DidFinishFrame(size_t remaining_frames) override {}

void AddObserver(BeginFrameObserver* obs) final;

void RemoveObserver(BeginFrameObserver* obs) final;

@@ -261,7 +261,8 @@ class CC_EXPORT BeginFrameSourceMultiplexer : public BeginFrameSourceMixIn,

// BeginFrameSource

bool NeedsBeginFrames() const override;

- void SetNeedsBeginFrames(bool needs_begin_frames) override;

+ // BeginFrameSourceMixIn

+ void OnNeedsBeginFramesChange(bool needs_begin_frames) override;

simonhong 2015/02/03 19:37:55 Below DidFinishFrame(...) overrides BeginFrameSour

Jimmy Jo 2015/02/04 01:46:47 Done.

void DidFinishFrame(size_t remaining_frames) override;

// Tracing

« no previous file with comments | « no previous file | cc/scheduler/begin_frame_source.cc » ('j') | cc/scheduler/begin_frame_source.cc » ('J')