make BeginFrameSourceMixIn's SetNeedsBeginFrame final

cc/scheduler/begin_frame_source.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_SCHEDULER_BEGIN_FRAME_SOURCE_H_
 #define CC_SCHEDULER_BEGIN_FRAME_SOURCE_H_
 
 #include <set>
 #include <string>
 
@@ skipping 120 matching lines @@
 //    BeginFrameSource.
 //  - Use the CallOnBeginFrame method to call to the observer(s).
 //  - Recommended (but not required) to call BeginFrameSourceMixIn::AsValueInto
 //    in their own AsValueInto implementation.
 class CC_EXPORT BeginFrameSourceMixIn : public BeginFrameSource {
  public:
   ~BeginFrameSourceMixIn() override {}
 
   // BeginFrameSource
   bool NeedsBeginFrames() const override;
-  void SetNeedsBeginFrames(bool needs_begin_frames) override;
+  void SetNeedsBeginFrames(bool needs_begin_frames) final;
   void DidFinishFrame(size_t remaining_frames) override {}
   void AddObserver(BeginFrameObserver* obs) final;
   void RemoveObserver(BeginFrameObserver* obs) final;
   void SetClientReady() override {}
 
   // Tracing support - Recommend (but not required) to call this implementation
   // in any override.
   void AsValueInto(base::debug::TracedValue* dict) const override;
 
  protected:
@@ skipping 102 matching lines @@
 
   // BeginFrameObserver
   // The mux is an BeginFrameObserver as it needs to proxy the OnBeginFrame
   // calls to preserve the monotonicity of the BeginFrameArgs when switching
   // sources.
   void OnBeginFrame(const BeginFrameArgs& args) override;
   const BeginFrameArgs LastUsedBeginFrameArgs() const override;
 
   // BeginFrameSource
   bool NeedsBeginFrames() const override;
-  void SetNeedsBeginFrames(bool needs_begin_frames) override;
+  // BeginFrameSourceMixIn
+  void OnNeedsBeginFramesChange(bool needs_begin_frames) override;

[simonhong, 2015/02/03 19:37:55]

Below DidFinishFrame(...) overrides BeginFrameSource::DidFinishFrame(...).
So line 264, 265 should be moved to other place.

[Jimmy Jo, 2015/02/04 01:46:47]

Done.

   void DidFinishFrame(size_t remaining_frames) override;
 
   // Tracing
   void AsValueInto(base::debug::TracedValue* dict) const override;
 
  protected:
   BeginFrameSourceMultiplexer();
   explicit BeginFrameSourceMultiplexer(base::TimeDelta minimum_interval);
 
   bool HasSource(BeginFrameSource* source);
   bool IsIncreasing(const BeginFrameArgs& args);
 
   base::TimeDelta minimum_interval_;
 
   BeginFrameSource* active_source_;
   std::set<BeginFrameSource*> source_list_;
 };
 
 }  // namespace cc
 
 #endif  // CC_SCHEDULER_BEGIN_FRAME_SOURCE_H_