chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc - Issue 891793002: Take a Profile when adding an incident to the incident reporting service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

Issue 891793002: Take a Profile when adding an incident to the incident reporting service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment and formatting Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc ('K') | « chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc ('k') | chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

index 547fb0973d0341d3f3c741dd5e540e903a7995ff..b6e3930c209ba6798ba5887275b4403139f632f4 100644

--- a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

@@ -31,11 +31,12 @@ class PreferenceValidationDelegateTest : public testing::Test {

invalid_keys_.push_back(std::string("one"));

invalid_keys_.push_back(std::string("two"));

instance_.reset(new safe_browsing::PreferenceValidationDelegate(

- base::Bind(&PreferenceValidationDelegateTest::AddIncident,

- base::Unretained(this))));

+ nullptr, base::Bind(&PreferenceValidationDelegateTest::AddIncident,

+ base::Unretained(this))));

}

- void AddIncident(scoped_ptr<safe_browsing::Incident> incident) {

+ void AddIncident(Profile* profile,

+ scoped_ptr<safe_browsing::Incident> incident) {

incidents_.push_back(incident.release());

}