chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc - Issue 891793002: Take a Profile when adding an incident to the incident reporting service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc

Issue 891793002: Take a Profile when adding an incident to the incident reporting service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment and formatting Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/add_incident_callback.h ('k') | chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc b/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc

index 769289271bf53d50b8ae0d58a201df6c3b8580ee..e4a58ca95f2ec1f690702ae6f6e2f78154b59ecf 100644

--- a/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc

@@ -78,8 +78,8 @@ void VerifyBinaryIntegrity(const AddIncidentCallback& callback) {

incident->set_allocated_signature(signature_info.release());

// Send the report.

- callback.Run(make_scoped_ptr(

- new BinaryIntegrityIncident(incident.Pass())));

+ callback.Run(nullptr, make_scoped_ptr(

+ new BinaryIntegrityIncident(incident.Pass())));

robertshield 2015/01/30 21:04:52 What do you think about having two types of callba

grt (UTC plus 2) 2015/01/30 21:16:29 Yeah, I thought about that. I wonder if an interfa

}