Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1379)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc

Issue 891793002: Take a Profile when adding an incident to the incident reporting service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment and formatting Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
diff --git a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
index 66253057a03be4ec055b4d524bc96dfc2b83a9ed..3324a7ec755845268d9e34ec8f7479d83df47e1c 100644
--- a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
+++ b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
@@ -246,7 +246,7 @@ class IncidentReportingServiceTest : public testing::Test {
// Adds a test incident to the service.
void AddTestIncident(Profile* profile) {
- instance_->GetAddIncidentCallback(profile).Run(MakeTestIncident(nullptr));
+ instance_->GetAddIncidentCallback().Run(profile, MakeTestIncident(nullptr));
}
// Registers the callback to be run for delayed analysis.
@@ -462,7 +462,7 @@ class IncidentReportingServiceTest : public testing::Test {
void OnDelayedAnalysis(const safe_browsing::AddIncidentCallback& callback) {
delayed_analysis_ran_ = true;
if (on_delayed_analysis_action_ == ON_DELAYED_ANALYSIS_ADD_INCIDENT)
- callback.Run(MakeTestIncident(nullptr));
+ callback.Run(nullptr, MakeTestIncident(nullptr));
}
// A mapping of profile name to its corresponding properties.
@@ -637,7 +637,7 @@ TEST_F(IncidentReportingServiceTest, TwoIncidentsTwoUploads) {
ExpectTestIncidentUploaded(1);
// Add a variation on the incident to the service.
- instance_->GetAddIncidentCallback(profile).Run(MakeTestIncident("leeches"));
+ instance_->GetAddIncidentCallback().Run(profile, MakeTestIncident("leeches"));
// Let all tasks run.
task_runner_->RunUntilIdle();
@@ -756,8 +756,8 @@ TEST_F(IncidentReportingServiceTest, ProcessWideTwoUploads) {
// Add the test incident.
safe_browsing::AddIncidentCallback add_incident(
- instance_->GetAddIncidentCallback(NULL));
- add_incident.Run(MakeTestIncident(nullptr));
+ instance_->GetAddIncidentCallback());
+ add_incident.Run(nullptr, MakeTestIncident(nullptr));
// Let all tasks run.
task_runner_->RunUntilIdle();
@@ -766,7 +766,7 @@ TEST_F(IncidentReportingServiceTest, ProcessWideTwoUploads) {
ExpectTestIncidentUploaded(1);
// Add a variation on the incident to the service.
- add_incident.Run(MakeTestIncident("leeches"));
+ add_incident.Run(nullptr, MakeTestIncident("leeches"));
// Let all tasks run.
task_runner_->RunUntilIdle();

Powered by Google App Engine
This is Rietveld 408576698