chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc - Issue 891793002: Take a Profile when adding an incident to the incident reporting service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc

Issue 891793002: Take a Profile when adding an incident to the incident reporting service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment and formatting Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc ('K') | « chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc ('k') | chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc

index 255117d31fb84361c22369f93fb0f189ca730098..2a901e4836456aba6c8678497d328c2c85138d3c 100644

--- a/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc

@@ -45,7 +45,7 @@ class BinaryIntegrityAnalyzerWinTest : public ::testing::Test {

public:

BinaryIntegrityAnalyzerWinTest();

- void OnAddIncident(scoped_ptr<Incident> incident);

+ void OnAddIncident(Profile* profile, scoped_ptr<Incident> incident);

protected:

bool callback_called_;

@@ -72,6 +72,7 @@ BinaryIntegrityAnalyzerWinTest::BinaryIntegrityAnalyzerWinTest()

// Mock the AddIncidentCallback so we can test that VerifyBinaryIntegrity

// adds an incident callback when a signature verification fails.

void BinaryIntegrityAnalyzerWinTest::OnAddIncident(

+ Profile* profile,

scoped_ptr<Incident> incident) {

callback_called_ = true;