dart2js: Refactoring, documentation, and a few bugfixes in Namer class.

pkg/compiler/lib/src/js_emitter/program_builder.dart

Index: pkg/compiler/lib/src/js_emitter/program_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder.dart
index a2fc45a1a0d00586c514bac55a3c4c33337c1a25..bdee67f7ddc528f290ba77410e6dc33ba268905b 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder.dart
@@ -200,7 +200,7 @@ class ProgramBuilder {
     JavaScriptConstantCompiler handler = backend.constants;
     ConstantValue initialValue = handler.getInitialValueFor(element).value;
     js.Expression code = _task.emitter.constantReference(initialValue);
-    String name = namer.getNameOfGlobalField(element);
+    String name = namer.globalPropertyName(element);
     bool isFinal = false;
     bool isLazy = false;
     return new StaticField(element,
@@ -232,7 +232,7 @@ class ProgramBuilder {
     // before code generation.
     if (code == null) return null;
 
-    String name = namer.getNameOfGlobalField(element);
+    String name = namer.globalPropertyName(element);
     bool isFinal = element.isFinal;
     bool isLazy = true;
     return new StaticField(element,
@@ -286,7 +286,7 @@ class ProgramBuilder {
 
     List<Field> instanceFields = _buildFields(element, false);
 
-    String name = namer.getNameOfClass(element);
+    String name = namer.className(element);
 
     return new Class(
         element, name, null, [], instanceFields, [], [], [], null,
@@ -350,7 +350,7 @@ class ProgramBuilder {
       isChecks.add(_buildStubMethod(name, code));
     });
 
-    String name = namer.getNameOfClass(element);
+    String name = namer.className(element);
     String holderName = namer.globalObjectFor(element);
     Holder holder = _registry.registerHolder(holderName);
     bool isInstantiated =
@@ -386,7 +386,7 @@ class ProgramBuilder {
   }
 
   Method _buildMethod(FunctionElement element, js.Expression code) {
-    String name = namer.getNameOfInstanceMember(element);
+    String name = namer.instanceMethodName(element);
     // TODO(floitsch): compute `needsTearOff`.
     return new Method(element, name, code, needsTearOff: false);
   }
@@ -494,7 +494,7 @@ class ProgramBuilder {
   }
 
   StaticMethod _buildStaticMethod(FunctionElement element) {
-    String name = namer.getNameOfMember(element);
+    String name = namer.methodPropertyName(element);
     String holder = namer.globalObjectFor(element);
     js.Expression code = backend.generatedCode[element];
     bool needsTearOff =