pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart - Issue 891673003: dart2js: Refactoring, documentation, and a few bugfixes in Namer class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

Issue 891673003: dart2js: Refactoring, documentation, and a few bugfixes in Namer class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: MEGAPATCH Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_backend/namer.dart ('K') | « pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/program_builder.dart » ('j') | tests/html/custom_element_name_clash_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

index 3096ff76f7413b5267a04ecf3c949aa4d7f32294..931a379b7b3409322fce15a59308b2934594ea31 100644

--- a/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

@@ -324,7 +324,7 @@ class NsmEmitter extends CodeEmitterHelper {

}

shortNames.splice.apply(shortNames, calculatedShortNames);

}

- }''', {'objectClass': js.string(namer.getNameOfClass(objectClass)),

+ }''', {'objectClass': js.string(namer.className(objectClass)),

'diffEncoding': js.string('$diffEncoding')}));

} else {

// No useDiffEncoding version.

@@ -333,7 +333,7 @@ class NsmEmitter extends CodeEmitterHelper {

statements.add(js.statement(

'var objectClassObject = processedClasses.collected[#objectClass],'

' shortNames = #diffEncoding.split(",")',

- {'objectClass': js.string(namer.getNameOfClass(objectClass)),

+ {'objectClass': js.string(namer.className(objectClass)),

'diffEncoding': js.string('$diffEncoding')}));

if (!minify) {

statements.add(js.statement('var longNames = #longs.split(",")',