pkg/compiler/lib/src/ssa/builder.dart - Issue 891673003: dart2js: Refactoring, documentation, and a few bugfixes in Namer class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 891673003: dart2js: Refactoring, documentation, and a few bugfixes in Namer class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Typo and TODO about clash in named parameters Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart ('K') | « pkg/compiler/lib/src/js_emitter/program_builder.dart ('k') | pkg/compiler/lib/src/ssa/codegen.dart » ('j') | tests/compiler/dart2js/pretty_parameter_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/ssa/builder.dart

diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart

index 1b10d11747a3667c5634b564ec74b0c223321761..537c2a418e5e15c48f9a9e0f4f4f315c2155f689 100644

--- a/pkg/compiler/lib/src/ssa/builder.dart

+++ b/pkg/compiler/lib/src/ssa/builder.dart

@@ -4088,7 +4088,7 @@ class SsaBuilder extends ResolvedVisitor {

// TODO(ahe): Creating a string here is unfortunate. It is slow (due to

// string concatenation in the implementation), and may prevent

// segmentation of '$'.

- String substitutionNameString = backend.namer.getNameForRti(cls);

+ String substitutionNameString = backend.namer.getRuntimeTypeName(cls);

HInstruction substitutionName = graph.addConstantString(

new ast.LiteralDartString(substitutionNameString), compiler);

pushInvokeStatic(null,