Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder.dart

Issue 891673003: dart2js: Refactoring, documentation, and a few bugfixes in Namer class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Typo and TODO about clash in named parameters Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/program_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder.dart
index a2fc45a1a0d00586c514bac55a3c4c33337c1a25..e3bf3c690981988108759442f60f37601b88fa69 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder.dart
@@ -200,7 +200,7 @@ class ProgramBuilder {
JavaScriptConstantCompiler handler = backend.constants;
ConstantValue initialValue = handler.getInitialValueFor(element).value;
js.Expression code = _task.emitter.constantReference(initialValue);
- String name = namer.getNameOfGlobalField(element);
+ String name = namer.globalPropertyName(element);
bool isFinal = false;
bool isLazy = false;
return new StaticField(element,
@@ -232,7 +232,7 @@ class ProgramBuilder {
// before code generation.
if (code == null) return null;
- String name = namer.getNameOfGlobalField(element);
+ String name = namer.globalPropertyName(element);
bool isFinal = element.isFinal;
bool isLazy = true;
return new StaticField(element,
@@ -386,7 +386,7 @@ class ProgramBuilder {
}
Method _buildMethod(FunctionElement element, js.Expression code) {
- String name = namer.getNameOfInstanceMember(element);
+ String name = namer.instanceMethodName(element);
// TODO(floitsch): compute `needsTearOff`.
return new Method(element, name, code, needsTearOff: false);
}
@@ -494,7 +494,7 @@ class ProgramBuilder {
}
StaticMethod _buildStaticMethod(FunctionElement element) {
- String name = namer.getNameOfMember(element);
+ String name = namer.getNameOfMethod(element);
String holder = namer.globalObjectFor(element);
js.Expression code = backend.generatedCode[element];
bool needsTearOff =

Powered by Google App Engine
This is Rietveld 408576698