Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 891613003: faster edge re-sort, drop trailing edges (Closed)

Created:
5 years, 10 months ago by reed1
Modified:
5 years, 10 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

faster edge re-sort, drop trailing edges 1. drop edges that are wholly on the right (in the non-convex walker) 2. scan and swap once, instead of swapping as we go during re-sort BUG=skia: Committed: https://skia.googlesource.com/skia/+/38f1c00772539dcbeccbfa3c45d94bdc4acf3518

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -39 lines) Patch
M src/core/SkEdgeBuilder.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkEdgeBuilder.cpp View 1 4 chunks +7 lines, -7 lines 0 comments Download
M src/core/SkLineClipper.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkLineClipper.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M src/core/SkScan_Path.cpp View 1 2 5 chunks +33 lines, -26 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891613003/40001
5 years, 10 months ago (2015-02-06 22:04:04 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-06 22:04:04 UTC) #3
reed1
5 years, 10 months ago (2015-02-06 22:04:32 UTC) #6
caryclark
lgtm
5 years, 10 months ago (2015-02-06 22:06:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891613003/60001
5 years, 10 months ago (2015-02-06 22:13:23 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/38f1c00772539dcbeccbfa3c45d94bdc4acf3518
5 years, 10 months ago (2015-02-06 22:18:52 UTC) #11
reed2
5 years, 10 months ago (2015-02-07 02:06:59 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/910493002/ by reed@chromium.org.

The reason for reverting is: may be breaking layouttests....

Powered by Google App Engine
This is Rietveld 408576698