Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: components/enhanced_bookmarks/enhanced_bookmark_utils.h

Issue 891493003: [Android] Upstreamed Stars UMA from iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/enhanced_bookmarks.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/enhanced_bookmarks/enhanced_bookmark_utils.h
diff --git a/components/enhanced_bookmarks/enhanced_bookmark_utils.h b/components/enhanced_bookmarks/enhanced_bookmark_utils.h
index dc9cf3c85665fda96c7a4b5fef3b465e04ce0b46..05da5feb1297c35ecd94f635b4e67cc471915009 100644
--- a/components/enhanced_bookmarks/enhanced_bookmark_utils.h
+++ b/components/enhanced_bookmarks/enhanced_bookmark_utils.h
@@ -17,6 +17,22 @@ class BookmarkModel;
namespace enhanced_bookmarks {
+static const char kLaunchLocationUMA[] = "Stars.LaunchLocation";
+
+// Possible locations where a bookmark can be opened from.
+//
+// A Java counterpart will be generated for this enum.
+// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.enhancedbookmark
+enum LaunchLocation {
+ ALL_ITEMS,
noyau (Ping after 24h) 2015/02/04 12:53:40 As those values have significance outside of the c
Kibeom Kim (inactive) 2015/02/04 17:57:32 Done.
+ UNCATEGORIZED, // Deprecated.
+ FOLDER,
+ FILTER,
+ SEARCH,
+ BOOKMARK_EDITOR,
+ COUNT,
+};
noyau (Ping after 24h) 2015/02/04 12:53:40 Since this is used externally, I'd put a = 0 for t
lpromero 2015/02/04 13:33:36 They are considered as FOLDER.
+
// The vector is sorted in place.
// All of the bookmarks in |nodes| must be urls.
void SortBookmarksByName(std::vector<const BookmarkNode*>& nodes);
« no previous file with comments | « components/enhanced_bookmarks.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698