[Android] Upstreamed Stars UMA from iOS.

components/enhanced_bookmarks/enhanced_bookmark_utils.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARK_UTILS_H_
 #define COMPONENTS_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARK_UTILS_H_
 
 #include <set>
 #include <string>
 #include <vector>
 
 class BookmarkNode;
 
 namespace bookmarks {
 class BookmarkModel;
 }
 
 namespace enhanced_bookmarks {
 
+static const char kLaunchLocationUMA[] = "Stars.LaunchLocation";
+
+// Possible locations where a bookmark can be opened from.
+//
+// A Java counterpart will be generated for this enum.
+// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.enhancedbookmark
+enum LaunchLocation {
+  ALL_ITEMS,

[noyau (Ping after 24h), 2015/02/04 12:53:40]

As those values have significance outside of the code, please assign them
numbers 

ALL_ITEMs = 0;

[Kibeom Kim (inactive), 2015/02/04 17:57:32]

Done.

+  UNCATEGORIZED,  // Deprecated.
+  FOLDER,
+  FILTER,
+  SEARCH,
+  BOOKMARK_EDITOR,
+  COUNT,
+};

[noyau (Ping after 24h), 2015/02/04 12:53:40]

Since this is used externally, I'd put a = 0 for the first item.

I think we are now missing a TOP_LEVEL entry in there, for the three top level
folders.

[lpromero, 2015/02/04 13:33:36]

They are considered as FOLDER.

+
 // The vector is sorted in place.
 // All of the bookmarks in |nodes| must be urls.
 void SortBookmarksByName(std::vector<const BookmarkNode*>& nodes);
 
 // Returns the permanent nodes whose url children are considered uncategorized
 // and whose folder children should be shown in the bookmark menu.
 // |model| must be loaded.
 std::vector<const BookmarkNode*> PrimaryPermanentNodes(
     bookmarks::BookmarkModel* model);
 
 // Returns an unsorted vector of folders that are considered to be at the "root"
 // level of the bookmark hierarchy. Functionally, this means all direct
 // descendants of PrimaryPermanentNodes.
 std::vector<const BookmarkNode*> RootLevelFolders(
     bookmarks::BookmarkModel* model);
 
 // Returns whether |node| is a primary permanent node in the sense of
 // |PrimaryPermanentNodes|.
 bool IsPrimaryPermanentNode(const BookmarkNode* node,
                             bookmarks::BookmarkModel* model);
 
 // Returns the root level folder in which this node is directly, or indirectly
 // via subfolders, located.
 const BookmarkNode* RootLevelFolderForNode(const BookmarkNode* node,
                                            bookmarks::BookmarkModel* model);
 
 }  // namespace enhanced_bookmarks
 
 #endif  // COMPONENTS_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARK_UTILS_H_