Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 891473007: Fix type error in bb_device_steps that causes test_report to crash (Closed)

Created:
5 years, 10 months ago by Dirk Pranke
Modified:
5 years, 10 months ago
Reviewers:
jbudodrick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix type error in bb_device_steps that causes test_report to crash Apparently ~15 months ago I introduced a bug that causes the 'test_report' step to crash on the chromium.webkit WebKit Android Nexus 4 bot to crash if more than 10 tests fail, flake, or pass unexpectedly, and no one has noticed or at least dealt with it until now :(. TBR=jbudodrick@chromium.org BUG= Committed: https://crrev.com/d7cae31462097c866ebd25647cfc09b1ad94ad4e Cr-Commit-Position: refs/heads/master@{#315222}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891473007/1
5 years, 10 months ago (2015-02-07 23:37:13 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/24158)
5 years, 10 months ago (2015-02-08 01:05:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891473007/1
5 years, 10 months ago (2015-02-08 01:40:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-08 02:41:02 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-08 02:41:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7cae31462097c866ebd25647cfc09b1ad94ad4e
Cr-Commit-Position: refs/heads/master@{#315222}

Powered by Google App Engine
This is Rietveld 408576698